adamquaile commented on code in PR #3057: URL: https://github.com/apache/avro/pull/3057#discussion_r1700044839
########## composer.json: ########## @@ -3,16 +3,65 @@ "description": "Apache Avro™ is a data serialization system.", "minimum-stability": "stable", "license": "Apache-2.0", + "homepage": "http://avro.apache.org";, + "type": "library", + "keywords": [ + "RPC" + ], + "readme": "README.md", + "authors": [ + { + "name": "Apache Avro Developers", + "email": "d...@avro.apache.org", + "homepage": "http://avro.apache.org"; + } + ], + "support": { + "email": "d...@avro.apache.org", + "issues": "https://issues.apache.org/jira/browse/AVRO"; + }, "require": { - "beberlei/composer-monorepo-plugin": "0.16.5" Review Comment: My understanding here is that the monorepo plugin is designed to allow publishing multiple php packages from the same repository. The important part it's currently doing is using the [monorepo.json](https://github.com/apache/avro/blob/35b01df443445e5a9193b335b0416075ec469b3a/lang/php/monorepo.json) file as a discovery-mechanism of sorts to locate the php source files. Unless I'm missing something the `autoload.psr-4` section of this new version will serve that need instead via [PSR-4 autoloading](https://getcomposer.org/doc/04-schema.md#psr-4) and the `archive.exclude` with the exclamation mark ensures only the php parts of this repository are included. ~I think we could even delete the `monorepo.json` file too.~ Edit: I can see it's already deleted -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@avro.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
