jjatria commented on PR #3057: URL: https://github.com/apache/avro/pull/3057#issuecomment-2263232307
I made one additional change to `lang/php/test/test_helper.php` so it (like `build.sh`) points to the `vendor` directory at the repo root level rather than one inside `lang/php`. Locally, that allows the tests to pass, although I get this as a summary: > OK, but incomplete, skipped, or risky tests! > Tests: 415, Assertions: 969, Risky: 415. Most of the "risky" tests complain like this: ``` This test does not have a @covers annotation but is expected to have one ``` but that sees to me like it should be addressed on a separate PR to keep the scope limited. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
