adamquaile commented on code in PR #3057: URL: https://github.com/apache/avro/pull/3057#discussion_r1700166474
########## composer.json: ########## @@ -3,16 +3,65 @@ "description": "Apache Avro™ is a data serialization system.", "minimum-stability": "stable", "license": "Apache-2.0", + "homepage": "http://avro.apache.org";, + "type": "library", + "keywords": [ + "RPC" + ], + "readme": "README.md", + "authors": [ + { + "name": "Apache Avro Developers", + "email": "d...@avro.apache.org", + "homepage": "http://avro.apache.org"; + } + ], + "support": { + "email": "d...@avro.apache.org", + "issues": "https://issues.apache.org/jira/browse/AVRO"; + }, "require": { - "beberlei/composer-monorepo-plugin": "0.16.5" Review Comment: I also currently hit install issues with the old version. I'm testing with a brand new empty project, with the following `composer.json`: ```json { "require": { "apache/avro": "dev-main" }, "repositories": [ { "type": "vcs", "url": "https://github.com/apache/avro"; } ], "config": { "allow-plugins": { "beberlei/composer-monorepo-plugin": true } } } ``` ```bash composer install No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information. Loading composer repositories with package information Updating dependencies Lock file operations: 2 installs, 0 updates, 0 removals - Locking apache/avro (dev-main 35b01df) - Locking beberlei/composer-monorepo-plugin (v0.16.5) Writing lock file Installing dependencies from lock file (including require-dev) Package operations: 1 install, 1 update, 0 removals - Installing beberlei/composer-monorepo-plugin (v0.16.5): Extracting archive - Upgrading apache/avro (dev-AVRO-2843-packagist 4c1ec59 => dev-main 35b01df): Extracting archive Generating autoload files Generating autoload files for monorepo sub-packages with dev-dependencies. PHP Fatal error: Declaration of Monorepo\Composer\EventDispatcher::dispatch($eventName, ?Composer\EventDispatcher\Event $event = null) must be compatible with Composer\EventDispatcher\EventDispatcher::dispatch(?string $eventName, ?Composer\EventDispatcher\Event $event = null): int in /Users/aquaile/Development/avro-tests/vendor/beberlei/composer-monorepo-plugin/src/main/Monorepo/Composer/EventDispatcher.php on line 9 Fatal error: Declaration of Monorepo\Composer\EventDispatcher::dispatch($eventName, ?Composer\EventDispatcher\Event $event = null) must be compatible with Composer\EventDispatcher\EventDispatcher::dispatch(?string $eventName, ?Composer\EventDispatcher\Event $event = null): int in /Users/aquaile/Development/avro-tests/vendor/beberlei/composer-monorepo-plugin/src/main/Monorepo/Composer/EventDispatcher.php on line 9 ``` Pointing to the new branch with this works: ```json { "require": { "apache/avro": "dev-AVRO-2843-packagist" }, "repositories": [ { "type": "vcs", "url": "https://github.com/cv-library/avro"; } ] } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@avro.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
