KalleOlaviNiemitalo commented on code in PR #3231:
URL: https://github.com/apache/avro/pull/3231#discussion_r1823316117
##########
lang/csharp/versions.props:
##########
@@ -58,15 +58,15 @@
Please sort the packages alphabetically
-->
<PropertyGroup Label="Build, Test, Code Analysis, Benchmark Package
Versions">
- <BenchmarkDotNetVersion>0.13.10</BenchmarkDotNetVersion>
- <CoverletCollectorVersion>6.0.0</CoverletCollectorVersion>
- <CoverletMSBuildVersion>6.0.0</CoverletMSBuildVersion>
- <MicrosoftBuildFrameworkVersion>17.8.3</MicrosoftBuildFrameworkVersion>
-
<MicrosoftBuildUtilitiesCoreVersion>17.8.3</MicrosoftBuildUtilitiesCoreVersion>
- <MicrosoftCodeAnalysisVersion>4.7.0</MicrosoftCodeAnalysisVersion>
-
<MicrosoftCodeAnalysisCSharpVersion>4.7.0</MicrosoftCodeAnalysisCSharpVersion>
-
<MicrosoftCodeAnalysisCSharpCodeStyleVersion>4.7.0</MicrosoftCodeAnalysisCSharpCodeStyleVersion>
-
<MicrosoftCodeAnalysisNetAnalyzersVersion>8.0.0</MicrosoftCodeAnalysisNetAnalyzersVersion>
+ <BenchmarkDotNetVersion>0.14.0</BenchmarkDotNetVersion>
+ <CoverletCollectorVersion>6.0.2</CoverletCollectorVersion>
+ <CoverletMSBuildVersion>6.0.2</CoverletMSBuildVersion>
+ <MicrosoftBuildFrameworkVersion>17.12.6</MicrosoftBuildFrameworkVersion>
+
<MicrosoftBuildUtilitiesCoreVersion>17.12.6</MicrosoftBuildUtilitiesCoreVersion>
Review Comment:
These MSBuild version changes worry me. The properties are used in
`lang/csharp/src/apache/msbuild/Avro.msbuild.csproj` so does the custom task
assembly become impossible to load into an older version of MSBuild, e.g. in an
older version of Visual Studio? There is a comment above the PropertyGroup
that claims these are safe to upgrade, but I'm not sure it is true.
In contrast, the Microsoft.CodeAnalysis APIs are used in tests only, so
those packages are safe to uograde.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
