zcsizmadia commented on code in PR #3231:
URL: https://github.com/apache/avro/pull/3231#discussion_r1823394073
##########
lang/csharp/versions.props:
##########
@@ -58,15 +58,15 @@
Please sort the packages alphabetically
-->
<PropertyGroup Label="Build, Test, Code Analysis, Benchmark Package
Versions">
- <BenchmarkDotNetVersion>0.13.10</BenchmarkDotNetVersion>
- <CoverletCollectorVersion>6.0.0</CoverletCollectorVersion>
- <CoverletMSBuildVersion>6.0.0</CoverletMSBuildVersion>
- <MicrosoftBuildFrameworkVersion>17.8.3</MicrosoftBuildFrameworkVersion>
-
<MicrosoftBuildUtilitiesCoreVersion>17.8.3</MicrosoftBuildUtilitiesCoreVersion>
- <MicrosoftCodeAnalysisVersion>4.7.0</MicrosoftCodeAnalysisVersion>
-
<MicrosoftCodeAnalysisCSharpVersion>4.7.0</MicrosoftCodeAnalysisCSharpVersion>
-
<MicrosoftCodeAnalysisCSharpCodeStyleVersion>4.7.0</MicrosoftCodeAnalysisCSharpCodeStyleVersion>
-
<MicrosoftCodeAnalysisNetAnalyzersVersion>8.0.0</MicrosoftCodeAnalysisNetAnalyzersVersion>
+ <BenchmarkDotNetVersion>0.14.0</BenchmarkDotNetVersion>
+ <CoverletCollectorVersion>6.0.2</CoverletCollectorVersion>
+ <CoverletMSBuildVersion>6.0.2</CoverletMSBuildVersion>
+ <MicrosoftBuildFrameworkVersion>17.12.6</MicrosoftBuildFrameworkVersion>
+
<MicrosoftBuildUtilitiesCoreVersion>17.12.6</MicrosoftBuildUtilitiesCoreVersion>
Review Comment:
The MSBuilkd package is not distributed to nuget and that source was not
maintained for a long time. Additionally IMO it should be retireed from the
source code, because avrogen is the tool for code generation and MS recommends
not using MSBuild task for more complex cases. Additionally to this AFAIK
MSBuild tasks are backwards compatible with older (to a certain level) VS
IDEs. Mostly they are netstandard2.0 libraries with standard interfaces and the
MSBuild.Framework librariries do not come really into play with the executing
VS IDE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
