zcsizmadia commented on code in PR #3231:
URL: https://github.com/apache/avro/pull/3231#discussion_r1824379908
##########
lang/csharp/versions.props:
##########
@@ -58,15 +58,15 @@
Please sort the packages alphabetically
-->
<PropertyGroup Label="Build, Test, Code Analysis, Benchmark Package
Versions">
- <BenchmarkDotNetVersion>0.13.10</BenchmarkDotNetVersion>
- <CoverletCollectorVersion>6.0.0</CoverletCollectorVersion>
- <CoverletMSBuildVersion>6.0.0</CoverletMSBuildVersion>
- <MicrosoftBuildFrameworkVersion>17.8.3</MicrosoftBuildFrameworkVersion>
-
<MicrosoftBuildUtilitiesCoreVersion>17.8.3</MicrosoftBuildUtilitiesCoreVersion>
- <MicrosoftCodeAnalysisVersion>4.7.0</MicrosoftCodeAnalysisVersion>
-
<MicrosoftCodeAnalysisCSharpVersion>4.7.0</MicrosoftCodeAnalysisCSharpVersion>
-
<MicrosoftCodeAnalysisCSharpCodeStyleVersion>4.7.0</MicrosoftCodeAnalysisCSharpCodeStyleVersion>
-
<MicrosoftCodeAnalysisNetAnalyzersVersion>8.0.0</MicrosoftCodeAnalysisNetAnalyzersVersion>
+ <BenchmarkDotNetVersion>0.14.0</BenchmarkDotNetVersion>
+ <CoverletCollectorVersion>6.0.2</CoverletCollectorVersion>
+ <CoverletMSBuildVersion>6.0.2</CoverletMSBuildVersion>
+ <MicrosoftBuildFrameworkVersion>17.12.6</MicrosoftBuildFrameworkVersion>
+
<MicrosoftBuildUtilitiesCoreVersion>17.12.6</MicrosoftBuildUtilitiesCoreVersion>
Review Comment:
Roger. I will leave the MSBuild project here for now and lets deal with what
version of nuget package we will need once we succesfully revive it.
m
Just to share my memory so at least 2 of us might remeber in the future :)
The original issue I faced years ago when I tried to make this a published
nupkg was that MSBild tasks have trouble loading external dll dependencies
properly. In our case, it was our own Avro main dll. All compiles and builds
fine of course, until you need to load the Task nuget package. Lets hope they
need some improvement. I remember there was some discussion back then to create
a "fat" msbuild task package which contained the avro dlls, however the final
decision was to leave it for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
