Kriskras99 commented on code in PR #382:
URL: https://github.com/apache/avro-rs/pull/382#discussion_r2661595973


##########
avro/src/schema.rs:
##########
@@ -134,7 +134,7 @@ pub enum Schema {
     /// An instant in local time represented as the number of nanoseconds 
after the UNIX epoch.
     LocalTimestampNanos,
     /// An amount of time defined by a number of months, days and milliseconds.
-    Duration,
+    Duration(FixedSchema),

Review Comment:
   I agree with @jdarais, I think it's unlikely that Duration will get a new 
schema and code using it will break anyway.
   Let's keep it at `Duration(FixedSchema)`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to