jdarais commented on code in PR #382:
URL: https://github.com/apache/avro-rs/pull/382#discussion_r2663602021


##########
avro/src/schema.rs:
##########
@@ -2629,7 +2663,6 @@ pub mod derive {
     impl_schema!(f64, Schema::Double);
     impl_schema!(String, Schema::String);
     impl_schema!(uuid::Uuid, Schema::Uuid(UuidSchema::String));
-    impl_schema!(core::time::Duration, Schema::Duration);

Review Comment:
   I went ahead and added this to the PR, since it's probably better than 
removing the `AvroSchemaComponent` for `core::time::Duration` entirely.  I'm 
happy to make any other changes based on feedback.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to