martin-g commented on code in PR #382:
URL: https://github.com/apache/avro-rs/pull/382#discussion_r2663954922
##########
avro/src/schema_equality.rs:
##########
@@ -165,6 +163,8 @@ impl SchemataEq for StructFieldEq {
) => {
self.compare(items_one, items_two)
}
Review Comment:
```suggestion
}
(Schema::Array(_), _) => false,
```
##########
avro/src/serde/de.rs:
##########
Review Comment:
I think we missed to add arms for Uuid, Decimal and Duration here to support
`from_value::<Vec<u8>>(...)`
##########
avro/src/schema.rs:
##########
@@ -2722,6 +2755,29 @@ pub mod derive {
T::get_schema_in_ctxt(named_schemas, enclosing_namespace)
}
}
+
+ impl AvroSchemaComponent for core::time::Duration {
+ fn get_schema_in_ctxt(
+ named_schemas: &mut Names,
+ enclosing_namespace: &Namespace,
+ ) -> Schema {
+ let name = Name {
Review Comment:
`let name =
Name::new("duration")?.fully_qualified_name(enclosing_namespace);`
##########
avro/src/schema_equality.rs:
##########
@@ -165,6 +163,8 @@ impl SchemataEq for StructFieldEq {
) => {
self.compare(items_one, items_two)
}
+ (Schema::Duration(FixedSchema { size: size_one, ..}),
Schema::Duration(FixedSchema { size: size_two, ..})) => size_one == size_two,
+ (Schema::Duration(_), _) => false,
(Schema::Array(_), _) => false,
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
