[ https://issues.apache.org/jira/browse/BEAM-4176?focusedWorklogId=154871&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-154871 ]
ASF GitHub Bot logged work on BEAM-4176: ---------------------------------------- Author: ASF GitHub Bot Created on: 16/Oct/18 13:49 Start Date: 16/Oct/18 13:49 Worklog Time Spent: 10m Work Description: tweise commented on a change in pull request #6592: [BEAM-4176] Enable Post Commit JAVA PVR tests for Flink URL: https://github.com/apache/beam/pull/6592#discussion_r225547350 ########## File path: runners/flink/src/main/java/org/apache/beam/runners/flink/translation/functions/ReferenceCountingFlinkExecutableStageContextFactory.java ########## @@ -115,6 +115,7 @@ private void scheduleRelease(JobInfo jobInfo) { int environmentCacheTTLMillis = pipelineOptions.as(PortablePipelineOptions.class).getEnvironmentCacheMillis(); if (environmentCacheTTLMillis > 0) { + // Do immediate cleanup if this class is not loaded on Flink parent classloader. if (this.getClass().getClassLoader() != ExecutionEnvironment.class.getClassLoader()) { Review comment: @mxm did you verify that this works? If so, then +1 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 154871) Time Spent: 35h 20m (was: 35h 10m) > Java: Portable batch runner passes all ValidatesRunner tests that > non-portable runner passes > -------------------------------------------------------------------------------------------- > > Key: BEAM-4176 > URL: https://issues.apache.org/jira/browse/BEAM-4176 > Project: Beam > Issue Type: Bug > Components: runner-flink > Reporter: Ben Sidhom > Assignee: Ankur Goenka > Priority: Major > Attachments: 81VxNWtFtke.png, Screen Shot 2018-08-14 at 4.18.31 > PM.png, Screen Shot 2018-09-03 at 11.07.38 AM.png > > Time Spent: 35h 20m > Remaining Estimate: 0h > > We need this as a sanity check that runner execution is correct. -- This message was sent by Atlassian JIRA (v7.6.3#76005)