[
https://issues.apache.org/jira/browse/BEAM-4176?focusedWorklogId=155016&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-155016
]
ASF GitHub Bot logged work on BEAM-4176:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Oct/18 17:24
Start Date: 16/Oct/18 17:24
Worklog Time Spent: 10m
Work Description: angoenka commented on a change in pull request #6592:
[BEAM-4176] Enable Post Commit JAVA PVR tests for Flink
URL: https://github.com/apache/beam/pull/6592#discussion_r225635682
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/functions/ReferenceCountingFlinkExecutableStageContextFactory.java
##########
@@ -115,6 +115,7 @@ private void scheduleRelease(JobInfo jobInfo) {
int environmentCacheTTLMillis =
pipelineOptions.as(PortablePipelineOptions.class).getEnvironmentCacheMillis();
if (environmentCacheTTLMillis > 0) {
+ // Do immediate cleanup if this class is not loaded on Flink parent
classloader.
if (this.getClass().getClassLoader() !=
ExecutionEnvironment.class.getClassLoader()) {
Review comment:
FlinkUserCodeClassloader seems to have been removed since Flink 1.1 so can't
use it.
This PR says that flink now loads all flink classes to the parent class
loader https://github.com/apache/flink/pull/4891
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 155016)
Time Spent: 35h 50m (was: 35h 40m)
> Java: Portable batch runner passes all ValidatesRunner tests that
> non-portable runner passes
> --------------------------------------------------------------------------------------------
>
> Key: BEAM-4176
> URL: https://issues.apache.org/jira/browse/BEAM-4176
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Ben Sidhom
> Assignee: Ankur Goenka
> Priority: Major
> Attachments: 81VxNWtFtke.png, Screen Shot 2018-08-14 at 4.18.31
> PM.png, Screen Shot 2018-09-03 at 11.07.38 AM.png
>
> Time Spent: 35h 50m
> Remaining Estimate: 0h
>
> We need this as a sanity check that runner execution is correct.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
