[
https://issues.apache.org/jira/browse/BEAM-4176?focusedWorklogId=155035&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-155035
]
ASF GitHub Bot logged work on BEAM-4176:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Oct/18 17:54
Start Date: 16/Oct/18 17:54
Worklog Time Spent: 10m
Work Description: mxm commented on a change in pull request #6592:
[BEAM-4176] Enable Post Commit JAVA PVR tests for Flink
URL: https://github.com/apache/beam/pull/6592#discussion_r225645564
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/functions/ReferenceCountingFlinkExecutableStageContextFactory.java
##########
@@ -115,6 +115,7 @@ private void scheduleRelease(JobInfo jobInfo) {
int environmentCacheTTLMillis =
pipelineOptions.as(PortablePipelineOptions.class).getEnvironmentCacheMillis();
if (environmentCacheTTLMillis > 0) {
+ // Do immediate cleanup if this class is not loaded on Flink parent
classloader.
if (this.getClass().getClassLoader() !=
ExecutionEnvironment.class.getClassLoader()) {
Review comment:
*Flink* classes (org.apache.flink.*) are always loaded through the parent
classloader. The loaded class are always tight to the classloader which was
used to load them.
All other classes are first loaded through the child classloader, then the
parent by default.
```yaml
classloader.resolve-order: Whether Flink should use a child-first
ClassLoader when loading user-code classes or a parent-first ClassLoader. Can
be one of parent-first or child-first. (default: child-first)
```
https://ci.apache.org/projects/flink/flink-docs-release-1.5/ops/config.html#common-options
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 155035)
Time Spent: 36.5h (was: 36h 20m)
> Java: Portable batch runner passes all ValidatesRunner tests that
> non-portable runner passes
> --------------------------------------------------------------------------------------------
>
> Key: BEAM-4176
> URL: https://issues.apache.org/jira/browse/BEAM-4176
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Ben Sidhom
> Assignee: Ankur Goenka
> Priority: Major
> Attachments: 81VxNWtFtke.png, Screen Shot 2018-08-14 at 4.18.31
> PM.png, Screen Shot 2018-09-03 at 11.07.38 AM.png
>
> Time Spent: 36.5h
> Remaining Estimate: 0h
>
> We need this as a sanity check that runner execution is correct.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
