[
https://issues.apache.org/jira/browse/BEAM-6122?focusedWorklogId=169483&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-169483
]
ASF GitHub Bot logged work on BEAM-6122:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Nov/18 20:38
Start Date: 26/Nov/18 20:38
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#7129: [BEAM-6122] Update committer guidelines
URL: https://github.com/apache/beam/pull/7129#discussion_r236416923
##########
File path: website/src/contribute/index.md
##########
@@ -172,6 +174,9 @@ To contribute code, you need
Use `R: @username` in the pull request to notify a reviewer.
1. If you don't get any response in 3 business days, email the dev@ list to
ask for someone to look at your pull
request.
+1. Review feedback typically leads to follow-up changes. Please add these
changes as additional "fixup" commits to the
Review comment:
I don't think we agreed on this, did we? This used to be critical for GitHub
to not lose comments, but I think that is no longer the case. I see a lot of
PRs that don't do this and it seems OK. In fact, when a large PR is reviewed
incrementally like this I think it tends to let in worse changes because the
increments after the first round look OK even though the resulting code is not
so good.
FWIW reviewable.io does not require this and has its own incremental review
that we have toyed with. Anyone can choose to use it on a per-review basis.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 169483)
> Update committer guidelines
> ---------------------------
>
> Key: BEAM-6122
> URL: https://issues.apache.org/jira/browse/BEAM-6122
> Project: Beam
> Issue Type: Task
> Components: website
> Reporter: Thomas Weise
> Assignee: Thomas Weise
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Per discussion in
> [https://lists.apache.org/thread.html/6d922820d6fc352479f88e5c8737f2c8893ddb706a1e578b50d28948@%3Cdev.beam.apache.org%3E]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
