[
https://issues.apache.org/jira/browse/BEAM-6122?focusedWorklogId=169496&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-169496
]
ASF GitHub Bot logged work on BEAM-6122:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Nov/18 21:01
Start Date: 26/Nov/18 21:01
Worklog Time Spent: 10m
Work Description: swegner commented on issue #7129: [BEAM-6122] Update
committer guidelines
URL: https://github.com/apache/beam/pull/7129#issuecomment-441796400
In general, I believe that manual processes should be made as simple as
possible and have failure-modes which give timely and actionable feedback.
Some of these policies (like tagging a JIRA on every commit) would be very
easy to validate in a pre-commit ([the website build.gradle gives an example of
interacting with Git from
Gradle](https://github.com/apache/beam/blob/3a4da9cd9459605c0086c2db57eae680e0862d43/website/build.gradle#L194)).
But, the workflow for fixing up commit messages takes some degree of Git
mastery (`git rebase -i`). It's not a huge leap, but it adds the requirement
that all contributors known intermediate/advanced Git (or always write
compliant commit messages on the first try).
A simpler failure mode would be something like: "*If each commit is tagged
with a JIRA, individual commits will be retained during merge; otherwise
commiters should squash and merge a single commit with JIRA information from
the PR.*"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 169496)
Time Spent: 2h 40m (was: 2.5h)
> Update committer guidelines
> ---------------------------
>
> Key: BEAM-6122
> URL: https://issues.apache.org/jira/browse/BEAM-6122
> Project: Beam
> Issue Type: Task
> Components: website
> Reporter: Thomas Weise
> Assignee: Thomas Weise
> Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Per discussion in
> [https://lists.apache.org/thread.html/6d922820d6fc352479f88e5c8737f2c8893ddb706a1e578b50d28948@%3Cdev.beam.apache.org%3E]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
