[
https://issues.apache.org/jira/browse/BEAM-6122?focusedWorklogId=169501&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-169501
]
ASF GitHub Bot logged work on BEAM-6122:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Nov/18 21:22
Start Date: 26/Nov/18 21:22
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #7129: [BEAM-6122]
Update committer guidelines
URL: https://github.com/apache/beam/pull/7129#issuecomment-441802729
I really like Scott's latest points. Another aspect here is that the
instructions for new contributors should be primarily helpful and welcoming,
and avoid being prescriptive or pedantic. And _concise_. We want them to have
an easy onramp, so we need enough tips, but we also don't want to discourage
their contributor either by excessive demands or an intimidatingly large amount
of instruction. My biggest goal is for them to open a PR and have a good
interaction with a reviewer. I don't want to put anything in the way of that.
That's why rules for policing our more experienced members should be clearly
separate. As an extremely common special case, if someone thinks they already
know how to open a PR, I want to get out of the way and let them do that, and
work out the rest once we are in conversation. Putting this stuff in Jenkins is
great not only for the usual reasons for automation but also because it makes
iteration on it self-service.
Knowledgeable committers can take on additional chores and/or chat with the
contributor about things on the PR. I do think Beam committers can be expected
to know `rebase -i` and how to push to a contributor's branch, or else abstain
from merging PRs.
On the automation front, just noting that we have 1575 non-merge commits on
`master` since Oct 1 (choosing a recent date to avoid any differences in older
policies) of which 454 are tagged with a Jira. I don't think that 2/3 of the
commits are out of line. But I also think forcing folks to just tag them with
the Jira they happen to also be addressing is fine. It is a really nice way to
handle the "should I [ask for] squash or not?" problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 169501)
Time Spent: 2h 50m (was: 2h 40m)
> Update committer guidelines
> ---------------------------
>
> Key: BEAM-6122
> URL: https://issues.apache.org/jira/browse/BEAM-6122
> Project: Beam
> Issue Type: Task
> Components: website
> Reporter: Thomas Weise
> Assignee: Thomas Weise
> Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Per discussion in
> [https://lists.apache.org/thread.html/6d922820d6fc352479f88e5c8737f2c8893ddb706a1e578b50d28948@%3Cdev.beam.apache.org%3E]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
