[
https://issues.apache.org/jira/browse/BEAM-6122?focusedWorklogId=170681&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-170681
]
ASF GitHub Bot logged work on BEAM-6122:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Nov/18 15:54
Start Date: 29/Nov/18 15:54
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #7129:
[BEAM-6122] Update committer guidelines
URL: https://github.com/apache/beam/pull/7129#discussion_r237545152
##########
File path: website/src/contribute/index.md
##########
@@ -172,6 +174,9 @@ To contribute code, you need
Use `R: @username` in the pull request to notify a reviewer.
1. If you don't get any response in 3 business days, email the dev@ list to
ask for someone to look at your pull
request.
+1. Review feedback typically leads to follow-up changes. Please add these
changes as additional "fixup" commits to the
Review comment:
IIRC, github comments are tied to diffs, so they can be lost if the code
changes too much and the commits are gone. I personally like seeing just the
changes, as it gives me the choice of viewing everything vs. the incremental
diff (and the default is still everything). If consensus isn't obvious here,
maybe back to the list?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 170681)
Time Spent: 4h (was: 3h 50m)
> Update committer guidelines
> ---------------------------
>
> Key: BEAM-6122
> URL: https://issues.apache.org/jira/browse/BEAM-6122
> Project: Beam
> Issue Type: Task
> Components: website
> Reporter: Thomas Weise
> Assignee: Thomas Weise
> Priority: Major
> Time Spent: 4h
> Remaining Estimate: 0h
>
> Per discussion in
> [https://lists.apache.org/thread.html/6d922820d6fc352479f88e5c8737f2c8893ddb706a1e578b50d28948@%3Cdev.beam.apache.org%3E]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
