[ https://issues.apache.org/jira/browse/BEAM-6159?focusedWorklogId=172127&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-172127 ]
ASF GitHub Bot logged work on BEAM-6159: ---------------------------------------- Author: ASF GitHub Bot Created on: 05/Dec/18 01:41 Start Date: 05/Dec/18 01:41 Worklog Time Spent: 10m Work Description: boyuanzz commented on a change in pull request #7015: [BEAM-6159] Migrate dataflow portable worker using shared library to process bundle URL: https://github.com/apache/beam/pull/7015#discussion_r238905189 ########## File path: runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/BatchDataflowWorker.java ########## @@ -214,22 +215,34 @@ protected BatchDataflowWorker( // TODO: this conditional -> two implementations of common interface, or // param/injection if (DataflowRunner.hasExperiment(options, "beam_fn_api")) { - Function<MutableNetwork<Node, Edge>, Node> sdkFusedStage = - pipeline == null - ? RegisterNodeFunction.withoutPipeline( - IdGenerator::generate, sdkHarnessRegistry.beamFnStateApiServiceDescriptor()) - : RegisterNodeFunction.forPipeline( - pipeline, - IdGenerator::generate, - sdkHarnessRegistry.beamFnStateApiServiceDescriptor()); + Function<MutableNetwork<Node, Edge>, MutableNetwork<Node, Edge>> transformToRunnerNetwork; + Function<MutableNetwork<Node, Edge>, Node> sdkFusedStage; Function<MutableNetwork<Node, Edge>, MutableNetwork<Node, Edge>> lengthPrefixUnknownCoders = LengthPrefixUnknownCoders::forSdkNetwork; - Function<MutableNetwork<Node, Edge>, MutableNetwork<Node, Edge>> transformToRunnerNetwork = - new CreateRegisterFnOperationFunction( - IdGenerator::generate, - this::createPortNode, - lengthPrefixUnknownCoders.andThen(sdkFusedStage)); - + if (DataflowRunner.hasExperiment(options, "use_executable_stage_bundle_execution")) { + sdkFusedStage = new CreateExecutableStageNodeFunction(pipeline, IdGenerator::generate); + transformToRunnerNetwork = + new CreateRegisterFnOperationFunction( Review comment: discussed offline. CreateRegisterFnOperationFunction creates the sdk fused graph which is also needed in constructing ExecutableStage. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 172127) Time Spent: 10m Remaining Estimate: 0h > Dataflow portable runner harness should use ExecutableStage to process bundle > ----------------------------------------------------------------------------- > > Key: BEAM-6159 > URL: https://issues.apache.org/jira/browse/BEAM-6159 > Project: Beam > Issue Type: Task > Components: runner-dataflow > Reporter: Boyuan Zhang > Assignee: Boyuan Zhang > Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)