[ https://issues.apache.org/jira/browse/BEAM-6159?focusedWorklogId=172752&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-172752 ]
ASF GitHub Bot logged work on BEAM-6159: ---------------------------------------- Author: ASF GitHub Bot Created on: 06/Dec/18 18:13 Start Date: 06/Dec/18 18:13 Worklog Time Spent: 10m Work Description: lukecwik commented on a change in pull request #7015: [BEAM-6159] Migrate dataflow portable worker using shared library to process bundle URL: https://github.com/apache/beam/pull/7015#discussion_r239556452 ########## File path: runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/environment/StaticRemoteEnvironment.java ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.runners.fnexecution.environment; + +import net.jcip.annotations.ThreadSafe; +import org.apache.beam.model.pipeline.v1.RunnerApi.Environment; +import org.apache.beam.runners.fnexecution.control.InstructionRequestHandler; + +/** A {@link RemoteEnvironment} that connects to Dataflow runner harness. */ +@ThreadSafe +public class StaticRemoteEnvironment implements RemoteEnvironment { + + static StaticRemoteEnvironment create( + Environment environment, InstructionRequestHandler instructionRequestHandler) { + return new StaticRemoteEnvironment(environment, instructionRequestHandler); + } + + private final Object lock = new Object(); + private final Environment environment; + private final InstructionRequestHandler instructionRequestHandler; + + private boolean isClosed = false; + + private StaticRemoteEnvironment( + Environment environment, InstructionRequestHandler instructionRequestHandler) { + this.environment = environment; + this.instructionRequestHandler = instructionRequestHandler; + } + + @Override + public Environment getEnvironment() { + return this.environment; + } + + @Override + public InstructionRequestHandler getInstructionRequestHandler() { + return this.instructionRequestHandler; + } + + @Override + public void close() throws Exception { Review comment: nit: in a follow up PR, instead of using a lock object, make this method synchronized. Also prefer guard style statements: ``` if (isClosed) { return; } ... do other stuff to perform close ... ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 172752) > Dataflow portable runner harness should use ExecutableStage to process bundle > ----------------------------------------------------------------------------- > > Key: BEAM-6159 > URL: https://issues.apache.org/jira/browse/BEAM-6159 > Project: Beam > Issue Type: Task > Components: runner-dataflow > Reporter: Boyuan Zhang > Assignee: Boyuan Zhang > Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)