[
https://issues.apache.org/jira/browse/BEAM-6159?focusedWorklogId=172747&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-172747
]
ASF GitHub Bot logged work on BEAM-6159:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Dec/18 18:13
Start Date: 06/Dec/18 18:13
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #7015:
[BEAM-6159] Migrate dataflow portable worker using shared library to process
bundle
URL: https://github.com/apache/beam/pull/7015#discussion_r239555562
##########
File path:
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/IntrinsicMapTaskExecutorFactoryTest.java
##########
@@ -174,8 +174,8 @@ public void testCreateMapTaskExecutor() throws Exception {
mapTaskExecutorFactory.create(
null /* beamFnControlClientHandler */,
null /* beamFnDataService */,
- null, /* dataApiServiceDescriptor */
null /* beamFnStateService */,
+ null,
Review comment:
nit: in a follow up PR add the comment stating what the `null` represents.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 172747)
Time Spent: 1h 10m (was: 1h)
> Dataflow portable runner harness should use ExecutableStage to process bundle
> -----------------------------------------------------------------------------
>
> Key: BEAM-6159
> URL: https://issues.apache.org/jira/browse/BEAM-6159
> Project: Beam
> Issue Type: Task
> Components: runner-dataflow
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
