[
https://issues.apache.org/jira/browse/BEAM-4775?focusedWorklogId=201101&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-201101
]
ASF GitHub Bot logged work on BEAM-4775:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Feb/19 05:22
Start Date: 20/Feb/19 05:22
Worklog Time Spent: 10m
Work Description: ryan-williams commented on pull request #7868:
[BEAM-4775] MonitoringInfo URN tweaks
URL: https://github.com/apache/beam/pull/7868#discussion_r258337315
##########
File path: model/fn-execution/src/main/proto/beam_fn_api.proto
##########
@@ -337,24 +337,19 @@ message Annotation {
// MonitoringInfo protos.
message MonitoringInfoSpecs {
enum Enum {
- // TODO(ajamato): Add the PTRANSFORM name as a required label after
- // upgrading the python SDK.
- USER_COUNTER = 0 [(monitoring_info_spec) = {
- urn: "beam:metric:user:",
- type_urn: "beam:metrics:sum_int_64",
- }];
-
- ELEMENT_COUNT = 1 [(monitoring_info_spec) = {
+ ELEMENT_COUNT = 0 [(monitoring_info_spec) = {
urn: "beam:metric:element_count:v1",
type_urn: "beam:metrics:sum_int_64",
+ // TODO(ryan): we currently also generate this metric with
["PTRANSFORM"] labels, but it fails validation in
Review comment:
OK. I'll leave this for now, perhaps I can remove it before this gets
merged, if @Ardagan fixes it first, or lmk what you suggest!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 201101)
Time Spent: 13h 20m (was: 13h 10m)
> JobService should support returning metrics
> -------------------------------------------
>
> Key: BEAM-4775
> URL: https://issues.apache.org/jira/browse/BEAM-4775
> Project: Beam
> Issue Type: Bug
> Components: beam-model
> Reporter: Eugene Kirpichov
> Assignee: Ryan Williams
> Priority: Major
> Labels: triaged
> Time Spent: 13h 20m
> Remaining Estimate: 0h
>
> [https://github.com/apache/beam/blob/master/model/job-management/src/main/proto/beam_job_api.proto]
> currently doesn't appear to have a way for JobService to return metrics to a
> user, even though
> [https://github.com/apache/beam/blob/master/model/fn-execution/src/main/proto/beam_fn_api.proto]
> includes support for reporting SDK metrics to the runner harness.
>
> Metrics are apparently necessary to run any ValidatesRunner tests because
> PAssert needs to validate that the assertions succeeded. However, this
> statement should be double-checked: perhaps it's possible to somehow work
> with PAssert without metrics support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
