[ https://issues.apache.org/jira/browse/BEAM-4775?focusedWorklogId=201128&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-201128 ]
ASF GitHub Bot logged work on BEAM-4775: ---------------------------------------- Author: ASF GitHub Bot Created on: 20/Feb/19 07:40 Start Date: 20/Feb/19 07:40 Worklog Time Spent: 10m Work Description: ryan-williams commented on pull request #7876: [BEAM-4775] Clean up metric protos; support integer distributions, gauges URL: https://github.com/apache/beam/pull/7876#discussion_r258339552 ########## File path: model/fn-execution/src/main/proto/beam_fn_api.proto ########## @@ -553,11 +514,9 @@ message IntDistributionData { int64 max = 4; } -message DoubleDistributionData { - int64 count = 1; - double sum = 2; - double min = 3; - double max = 4; +message IntGaugeData { Review comment: Yea, in #7823 I support all the types here (counters, distributions, gauges) everywhere in Java; I *think* Python already supports them as well, but need to dig in to that further. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 201128) Time Spent: 14.5h (was: 14h 20m) > JobService should support returning metrics > ------------------------------------------- > > Key: BEAM-4775 > URL: https://issues.apache.org/jira/browse/BEAM-4775 > Project: Beam > Issue Type: Bug > Components: beam-model > Reporter: Eugene Kirpichov > Assignee: Ryan Williams > Priority: Major > Labels: triaged > Time Spent: 14.5h > Remaining Estimate: 0h > > [https://github.com/apache/beam/blob/master/model/job-management/src/main/proto/beam_job_api.proto] > currently doesn't appear to have a way for JobService to return metrics to a > user, even though > [https://github.com/apache/beam/blob/master/model/fn-execution/src/main/proto/beam_fn_api.proto] > includes support for reporting SDK metrics to the runner harness. > > Metrics are apparently necessary to run any ValidatesRunner tests because > PAssert needs to validate that the assertions succeeded. However, this > statement should be double-checked: perhaps it's possible to somehow work > with PAssert without metrics support. -- This message was sent by Atlassian JIRA (v7.6.3#76005)