[
https://issues.apache.org/jira/browse/BEAM-4775?focusedWorklogId=201108&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-201108
]
ASF GitHub Bot logged work on BEAM-4775:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Feb/19 05:31
Start Date: 20/Feb/19 05:31
Worklog Time Spent: 10m
Work Description: ryan-williams commented on issue #7868: [BEAM-4775]
MonitoringInfo URN tweaks
URL: https://github.com/apache/beam/pull/7868#issuecomment-465343573
> Just curious, what were you hoping to get out of this change in
particular? This is largely a bunch of renamings, was it too confusing before?
There are 2 renamings:
-
https://github.com/apache/beam/pull/7868/commits/0022bf9a6e12ae35b33d4bf06e0b53e9e0e7f1ad:
`MonitoringInfoLabels.{TRANSFORM → PTRANSFORM}`, per [this
`TODO(ajamato)`](https://github.com/apache/beam/commit/0022bf9a6e12ae35b33d4bf06e0b53e9e0e7f1ad#diff-4d226ebf3f70cf18449c29e82511a67eL439)
😄
-
https://github.com/apache/beam/pull/7868/commits/0715c199031548b218c425adbd7870d7460cbab2:
`USER_COUNTER_URN_PREFIX ` → `USER_METRIC_URN_PREFIX `
- (in `SimpleMonitoringInfoBuilder` and `MonitoringInfoUrns.Enum`)
- we need either this change, or to add new user-URN-prefixes for
distributions/gauges, afaict.
There are also 6 other commits here that each constitute minor forward
progress, I think:
-
https://github.com/apache/beam/pull/7868/commits/9d1e237ee5ae0182f43cfc9280a84021c1230d31:
`UserMonitoringInfoToCounterUpdateTransformer` had [a redundant definition of
`USER_COUNTER_URN_PREFIX`](https://github.com/apache/beam/commit/9d1e237ee5ae0182f43cfc9280a84021c1230d31#diff-a2189a7c97dace5f44f04e16a71b6468L56)
-
https://github.com/apache/beam/pull/7868/commits/84abbfafd9d75c7169af2625b5e72f539da6ede0:
consolidate two (different!) implementations of [parsing a MetricName from a
URN]
- etc.
Sorry if it just feels like dust. I thought these were all thematically
similar and a reasonable chunk to pull out of #7823 and reckon with
independently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 201108)
Time Spent: 13h 50m (was: 13h 40m)
> JobService should support returning metrics
> -------------------------------------------
>
> Key: BEAM-4775
> URL: https://issues.apache.org/jira/browse/BEAM-4775
> Project: Beam
> Issue Type: Bug
> Components: beam-model
> Reporter: Eugene Kirpichov
> Assignee: Ryan Williams
> Priority: Major
> Labels: triaged
> Time Spent: 13h 50m
> Remaining Estimate: 0h
>
> [https://github.com/apache/beam/blob/master/model/job-management/src/main/proto/beam_job_api.proto]
> Â currently doesn't appear to have a way for JobService to return metrics to a
> user, even though
> [https://github.com/apache/beam/blob/master/model/fn-execution/src/main/proto/beam_fn_api.proto]
> Â includes support for reporting SDK metrics to the runner harness.
> Â
> Metrics are apparently necessary to run any ValidatesRunner tests because
> PAssert needs to validate that the assertions succeeded. However, this
> statement should be double-checked: perhaps it's possible to somehow work
> with PAssert without metrics support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
