[
https://issues.apache.org/jira/browse/BEAM-7138?focusedWorklogId=236040&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-236040
]
ASF GitHub Bot logged work on BEAM-7138:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/May/19 23:07
Start Date: 01/May/19 23:07
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #8396: [BEAM-7138]
keep Java serialized coder in wire coder construction
URL: https://github.com/apache/beam/pull/8396#discussion_r280244024
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/IsmSideInputReader.java
##########
@@ -604,10 +606,11 @@ private IsmMultimapView(BoundedWindow window,
List<IsmReader<V>> readers) {
}
@Override
- public Iterable<V> get(K k) {
+ public Iterable<V> get(@Nullable K k) {
Review comment:
this change seems unrelated to what your trying to do
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 236040)
Time Spent: 1.5h (was: 1h 20m)
> keep Java serialized coder in length-prefixed wire coder construction
> ---------------------------------------------------------------------
>
> Key: BEAM-7138
> URL: https://issues.apache.org/jira/browse/BEAM-7138
> Project: Beam
> Issue Type: Improvement
> Components: java-fn-execution
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> don't replace Java serialized coder with byte array coder in length-prefixed
> wire coder construction.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
