[ 
https://issues.apache.org/jira/browse/BEAM-7138?focusedWorklogId=237094&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-237094
 ]

ASF GitHub Bot logged work on BEAM-7138:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/May/19 22:51
            Start Date: 03/May/19 22:51
    Worklog Time Spent: 10m 
      Work Description: ihji commented on issue #8396: [BEAM-7138] keep Java 
serialized coder in wire coder construction
URL: https://github.com/apache/beam/pull/8396#issuecomment-489263732
 
 
   The problem is that we're trying to support [`Read` 
transform](https://github.com/apache/beam/blob/0cc6b671de91719ea80b7aae5164a5500eff3d83/runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkBatchPortablePipelineTranslator.java#L554)
 in `FlinkRunner`. According to the current portability wire coder design, any 
transform handled by a runner itself can only generate a `PCollection` with 
either a standard or a length-prefixed byte array coder. If we have `Read` 
transform which generates a custom Java class, it will throw a 
`ClassCastException`. `PortableRunner` substitutes `Read` with `Impulse+DoFn` 
to avoid this problem. We can do the same thing in expansion service (#8491) 
and it fixes the issue I tried to solve with this PR.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 237094)
    Time Spent: 2.5h  (was: 2h 20m)

> keep Java serialized coder in length-prefixed wire coder construction
> ---------------------------------------------------------------------
>
>                 Key: BEAM-7138
>                 URL: https://issues.apache.org/jira/browse/BEAM-7138
>             Project: Beam
>          Issue Type: Improvement
>          Components: java-fn-execution
>            Reporter: Heejong Lee
>            Assignee: Heejong Lee
>            Priority: Major
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> don't replace Java serialized coder with byte array coder in length-prefixed 
> wire coder construction.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to