[
https://issues.apache.org/jira/browse/BEAM-7138?focusedWorklogId=236049&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-236049
]
ASF GitHub Bot logged work on BEAM-7138:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/May/19 23:16
Start Date: 01/May/19 23:16
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #8396: [BEAM-7138]
keep Java serialized coder in wire coder construction
URL: https://github.com/apache/beam/pull/8396#discussion_r280249060
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/wire/LengthPrefixUnknownCoders.java
##########
@@ -55,12 +56,16 @@ public static String addLengthPrefixedCoder(
// request to replace the coder with a byte array coder.
// 2) the requested coder is a known coder but not a length prefix coder.
In this case we
// rebuild the coder by recursively length prefixing any unknown
component coders.
- // 3) the requested coder is an unknown coder. In this case we either
wrap the requested coder
+ // 3) the requested coder is a serialized Java coder. In this case we
wrap the coder with
+ // a length prefix coder.
+ // 4) the requested coder is an unknown coder. In this case we either
wrap the requested coder
// with a length prefix coder or replace it with a length prefix byte
array coder.
if (ModelCoders.LENGTH_PREFIX_CODER_URN.equals(urn)) {
return replaceWithByteArrayCoder ? lengthPrefixedByteArrayCoderId :
coderId;
} else if (ModelCoders.urns().contains(urn)) {
return addForModelCoder(coderId, components, replaceWithByteArrayCoder);
+ } else if (CoderTranslation.JAVA_SERIALIZED_CODER_URN.equals(urn)) {
Review comment:
You'll want to find the location that is calling this code and see if it is
using the incorrect representation (or not remembering this duality).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 236049)
Time Spent: 2h 10m (was: 2h)
> keep Java serialized coder in length-prefixed wire coder construction
> ---------------------------------------------------------------------
>
> Key: BEAM-7138
> URL: https://issues.apache.org/jira/browse/BEAM-7138
> Project: Beam
> Issue Type: Improvement
> Components: java-fn-execution
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> don't replace Java serialized coder with byte array coder in length-prefixed
> wire coder construction.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
