[
https://issues.apache.org/jira/browse/BEAM-7528?focusedWorklogId=274135&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-274135
]
ASF GitHub Bot logged work on BEAM-7528:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jul/19 15:31
Start Date: 09/Jul/19 15:31
Worklog Time Spent: 10m
Work Description: kkucharc commented on pull request #8941: [BEAM-7528]
Save load test metrics according to distribution name
URL: https://github.com/apache/beam/pull/8941#discussion_r301652925
##########
File path:
sdks/python/apache_beam/testing/load_tests/load_test_metrics_utils.py
##########
@@ -138,8 +143,25 @@ def as_dict(self):
class CounterMetric(Metric):
def __init__(self, counter_dict, submit_timestamp, metric_id):
super(CounterMetric, self).__init__(submit_timestamp, metric_id)
- self.value = counter_dict.committed
self.label = str(counter_dict.key.metric.name)
+ self.value = counter_dict.committed
+
+
+class DistributionMetrics(Metric):
Review comment:
You are right, naming here isn't very accurate. To give more context:
Metrics such as counters or the runtime metric are just one value. Runtime
is evaluated from multiple distribution metrics, but distribution metric has 4
values inside (sum, mean, max, min). There was situation when metrics weren't
introduced exactly in test but in the pipelines in project (it happened in tfx
project) and I wasn't sure what should be saved in those cases, so I decided
that we should save everything.
Also it's not a dumb question :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 274135)
Time Spent: 3h 50m (was: 3h 40m)
> Save correctly Python Load Tests metrics according to it's namespace
> --------------------------------------------------------------------
>
> Key: BEAM-7528
> URL: https://issues.apache.org/jira/browse/BEAM-7528
> Project: Beam
> Issue Type: Bug
> Components: testing
> Reporter: Kasia Kucharczyk
> Assignee: Kasia Kucharczyk
> Priority: Major
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> Bug discovered when metrics monitored more than one distribution and saved
> all as `runtime`.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
