[
https://issues.apache.org/jira/browse/BEAM-7528?focusedWorklogId=276629&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-276629
]
ASF GitHub Bot logged work on BEAM-7528:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jul/19 11:39
Start Date: 15/Jul/19 11:39
Worklog Time Spent: 10m
Work Description: kkucharc commented on pull request #8941: [BEAM-7528]
Save load test metrics according to distribution name
URL: https://github.com/apache/beam/pull/8941#discussion_r303393135
##########
File path:
sdks/python/apache_beam/testing/load_tests/load_test_metrics_utils.py
##########
@@ -138,8 +143,25 @@ def as_dict(self):
class CounterMetric(Metric):
def __init__(self, counter_dict, submit_timestamp, metric_id):
super(CounterMetric, self).__init__(submit_timestamp, metric_id)
- self.value = counter_dict.committed
self.label = str(counter_dict.key.metric.name)
+ self.value = counter_dict.committed
+
+
+class DistributionMetrics(Metric):
+ def __init__(self, dists, submit_timestamp, metric_id, key):
Review comment:
Renaming it sounds reasonable. I'm changing it this way.
Your comment made me think that I may be wrong by assuming there is no
problem if someone would add measurements to the same distribution several
times during one pipeline. In BQ they would be redundantly saved with same
`id`, `label` and `timestamp` but with different `value`. It would be good to
differ them somehow to know how a saved distribution looks like.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 276629)
Time Spent: 4.5h (was: 4h 20m)
> Save correctly Python Load Tests metrics according to it's namespace
> --------------------------------------------------------------------
>
> Key: BEAM-7528
> URL: https://issues.apache.org/jira/browse/BEAM-7528
> Project: Beam
> Issue Type: Bug
> Components: testing
> Reporter: Kasia Kucharczyk
> Assignee: Kasia Kucharczyk
> Priority: Major
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> Bug discovered when metrics monitored more than one distribution and saved
> all as `runtime`.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
