[
https://issues.apache.org/jira/browse/BEAM-7528?focusedWorklogId=274939&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-274939
]
ASF GitHub Bot logged work on BEAM-7528:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jul/19 16:30
Start Date: 10/Jul/19 16:30
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #8941: [BEAM-7528]
Save load test metrics according to distribution name
URL: https://github.com/apache/beam/pull/8941#discussion_r300180233
##########
File path:
sdks/python/apache_beam/testing/load_tests/load_test_metrics_utils.py
##########
@@ -138,8 +143,25 @@ def as_dict(self):
class CounterMetric(Metric):
def __init__(self, counter_dict, submit_timestamp, metric_id):
super(CounterMetric, self).__init__(submit_timestamp, metric_id)
- self.value = counter_dict.committed
self.label = str(counter_dict.key.metric.name)
+ self.value = counter_dict.committed
+
+
+class DistributionMetrics(Metric):
Review comment:
It seems that the intent of `DistributionMetrics` is to capture multiple
metrics, however it inherits from a class that captures a single metric. Would
methods of the parent class even work correctly on objects of this class?
Should we consider introducing a class `DistributionMetric` for a singe metric?
Sorry if it's a dumb question - I am not very familiar with this
infrastructure yet. Also - what is an example of a distribution in this context?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 274939)
Time Spent: 4h 20m (was: 4h 10m)
> Save correctly Python Load Tests metrics according to it's namespace
> --------------------------------------------------------------------
>
> Key: BEAM-7528
> URL: https://issues.apache.org/jira/browse/BEAM-7528
> Project: Beam
> Issue Type: Bug
> Components: testing
> Reporter: Kasia Kucharczyk
> Assignee: Kasia Kucharczyk
> Priority: Major
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> Bug discovered when metrics monitored more than one distribution and saved
> all as `runtime`.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
