[ https://issues.apache.org/jira/browse/BEAM-7528?focusedWorklogId=285673&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-285673 ]
ASF GitHub Bot logged work on BEAM-7528: ---------------------------------------- Author: ASF GitHub Bot Created on: 31/Jul/19 11:23 Start Date: 31/Jul/19 11:23 Worklog Time Spent: 10m Work Description: tvalentyn commented on pull request #8941: [BEAM-7528] Save load test metrics according to distribution name URL: https://github.com/apache/beam/pull/8941#discussion_r300184215 ########## File path: sdks/python/apache_beam/testing/load_tests/load_test_metrics_utils.py ########## @@ -138,8 +143,25 @@ def as_dict(self): class CounterMetric(Metric): def __init__(self, counter_dict, submit_timestamp, metric_id): super(CounterMetric, self).__init__(submit_timestamp, metric_id) - self.value = counter_dict.committed self.label = str(counter_dict.key.metric.name) + self.value = counter_dict.committed + + +class DistributionMetrics(Metric): + def __init__(self, dists, submit_timestamp, metric_id, key): Review comment: also do multiple dists have the same dist label? I also wonder what is the relationship between label and metric_id - is there 1-1 correspondence? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 285673) Time Spent: 5h 40m (was: 5.5h) > Save correctly Python Load Tests metrics according to it's namespace > -------------------------------------------------------------------- > > Key: BEAM-7528 > URL: https://issues.apache.org/jira/browse/BEAM-7528 > Project: Beam > Issue Type: Bug > Components: testing > Reporter: Kasia Kucharczyk > Assignee: Kasia Kucharczyk > Priority: Major > Time Spent: 5h 40m > Remaining Estimate: 0h > > Load test framework considers all distribution metrics defined in a pipeline > as a `runtime` metric (which is defined by the loadtest framework), while > only `runtime` distribution metric should be considered as runtime. -- This message was sent by Atlassian JIRA (v7.6.14#76016)