[
https://issues.apache.org/jira/browse/BEAM-7528?focusedWorklogId=285729&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-285729
]
ASF GitHub Bot logged work on BEAM-7528:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Jul/19 12:48
Start Date: 31/Jul/19 12:48
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #8941: [BEAM-7528]
Save load test metrics according to distribution name
URL: https://github.com/apache/beam/pull/8941#discussion_r309199134
##########
File path:
sdks/python/apache_beam/testing/load_tests/load_test_metrics_utils.py
##########
@@ -138,8 +143,25 @@ def as_dict(self):
class CounterMetric(Metric):
def __init__(self, counter_dict, submit_timestamp, metric_id):
super(CounterMetric, self).__init__(submit_timestamp, metric_id)
- self.value = counter_dict.committed
self.label = str(counter_dict.key.metric.name)
+ self.value = counter_dict.committed
+
+
+class DistributionMetrics(Metric):
Review comment:
I see, looks like saving median would require changes to beam. Regarding
unknown distributions, I see following options:
1) Save sum, count, min, max, collected across all distributions associated
with a metric with the same name. In other words, total sum, total count, min
of minimums and max of maximums.
2) Save `(sum, count, min, max)` for each distribution without aggregation
(not sure if useful, but since we are exporting to bigquery, we can run a query
later to aggregate something we need).
3) register aggregators with an instance of MetricsReader. Registration will
take the name of the metric, and an aggregator instance that recieves a list of
all distribution readings, and computes desired output to store into Bigquery.
I think 2 is most flexible, but perhaps 1) is sufficient and will cover most
of the use-cases. Feel free to ask @robertwb or @pabloem for an opinion. 3
seems like overengineering at this point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 285729)
> Save correctly Python Load Tests metrics according to it's namespace
> --------------------------------------------------------------------
>
> Key: BEAM-7528
> URL: https://issues.apache.org/jira/browse/BEAM-7528
> Project: Beam
> Issue Type: Bug
> Components: testing
> Reporter: Kasia Kucharczyk
> Assignee: Kasia Kucharczyk
> Priority: Major
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
> Load test framework considers all distribution metrics defined in a pipeline
> as a `runtime` metric (which is defined by the loadtest framework), while
> only `runtime` distribution metric should be considered as runtime.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
