[
https://issues.apache.org/jira/browse/BEAM-7528?focusedWorklogId=285727&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-285727
]
ASF GitHub Bot logged work on BEAM-7528:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Jul/19 12:48
Start Date: 31/Jul/19 12:48
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #8941: [BEAM-7528]
Save load test metrics according to distribution name
URL: https://github.com/apache/beam/pull/8941#discussion_r309180800
##########
File path:
sdks/python/apache_beam/testing/load_tests/load_test_metrics_utils.py
##########
@@ -111,11 +112,15 @@ def _prepare_all_metrics(self, metrics):
insert_rows.append(counter_dict)
dists = metrics['distributions']
- if len(dists) > 0:
- runtime = RuntimeMetric(dists, submit_timestamp, metric_id)\
- .as_dict()
- insert_rows.append(runtime)
-
+ sorted_dists = sorted(dists, key=lambda x: x.key.metric.name)
Review comment:
re line 110: let's use brackets for implicit line continuation and remove
'\'. From PEP-0008:
> The preferred way of wrapping long lines is by using Python's implied line
continuation inside parentheses, brackets and braces
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 285727)
> Save correctly Python Load Tests metrics according to it's namespace
> --------------------------------------------------------------------
>
> Key: BEAM-7528
> URL: https://issues.apache.org/jira/browse/BEAM-7528
> Project: Beam
> Issue Type: Bug
> Components: testing
> Reporter: Kasia Kucharczyk
> Assignee: Kasia Kucharczyk
> Priority: Major
> Time Spent: 6h
> Remaining Estimate: 0h
>
> Load test framework considers all distribution metrics defined in a pipeline
> as a `runtime` metric (which is defined by the loadtest framework), while
> only `runtime` distribution metric should be considered as runtime.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
