[ https://issues.apache.org/jira/browse/BEAM-7909?focusedWorklogId=297489&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297489 ]
ASF GitHub Bot logged work on BEAM-7909: ---------------------------------------- Author: ASF GitHub Bot Created on: 19/Aug/19 23:23 Start Date: 19/Aug/19 23:23 Worklog Time Spent: 10m Work Description: Hannah-Jiang commented on pull request #9351: [BEAM-7909] support customized container for Python URL: https://github.com/apache/beam/pull/9351#discussion_r315451829 ########## File path: sdks/python/apache_beam/runners/portability/portable_runner.py ########## @@ -84,16 +84,10 @@ def __init__(self): @staticmethod def default_docker_image(): if 'USER' in os.environ: - if sys.version_info[0] == 2: - version_suffix = '' - elif sys.version_info[0:2] == (3, 5): - version_suffix = '3' - else: - version_suffix = '3' - # TODO(BEAM-7474): Use an image which has correct Python minor version. - logging.warning('Make sure that locally built Python SDK docker image ' - 'has Python %d.%d interpreter. See also: BEAM-7474.' % ( - sys.version_info[0], sys.version_info[1])) + version_suffix = ''.join([str(i) for i in sys.version_info[0:2]]) Review comment: `PortableRunnerTestWithLocalDocker` class at `portable_runner_test.py` will test this function. However, in order to run these tests, users should build docker images first, which I don't think all users need to do. Do we want to skip these tests at local? Is there any good practice I can refer? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 297489) Time Spent: 2h 40m (was: 2.5h) > Write integration tests to test customized containers > ----------------------------------------------------- > > Key: BEAM-7909 > URL: https://issues.apache.org/jira/browse/BEAM-7909 > Project: Beam > Issue Type: Sub-task > Components: build-system > Reporter: Hannah Jiang > Assignee: Hannah Jiang > Priority: Major > Time Spent: 2h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)