[
https://issues.apache.org/jira/browse/BEAM-7909?focusedWorklogId=297502&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297502
]
ASF GitHub Bot logged work on BEAM-7909:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Aug/19 23:55
Start Date: 19/Aug/19 23:55
Worklog Time Spent: 10m
Work Description: Hannah-Jiang commented on pull request #9351:
[BEAM-7909] support customized container for Python
URL: https://github.com/apache/beam/pull/9351#discussion_r315455095
##########
File path: sdks/python/container/build.gradle
##########
@@ -60,15 +51,13 @@ golang {
}
}
-docker {
- name containerImageName(name: "python")
- files "./build"
+task buildDocker {
Review comment:
I changed project structure of sdks/python/container.
Previously, build.gradle has a task called `docker` to build an image for
py2.
Now I left common tasks needed to create a docker image at this file and
moved out `docker` task to a separate file, like other python versions. This
makes it easy to retire py2 in future and also can make py2 image only.
(Previously, it was not possible.) However, now we cannot use `./gradlew -p
sdks/python/container docker` command anymore, because we should rename the
task. I renamed it to `buildDocker`, so the command will change to `./gradlew
-p sdks/python/container buildDocker`. Is this a good change? do we have a
better way to handle this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 297502)
Time Spent: 3h 10m (was: 3h)
> Write integration tests to test customized containers
> -----------------------------------------------------
>
> Key: BEAM-7909
> URL: https://issues.apache.org/jira/browse/BEAM-7909
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
> Reporter: Hannah Jiang
> Assignee: Hannah Jiang
> Priority: Major
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
