[ 
https://issues.apache.org/jira/browse/BEAM-7909?focusedWorklogId=297531&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297531
 ]

ASF GitHub Bot logged work on BEAM-7909:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Aug/19 01:19
            Start Date: 20/Aug/19 01:19
    Worklog Time Spent: 10m 
      Work Description: aaltay commented on pull request #9351: [BEAM-7909] 
support customized container for Python
URL: https://github.com/apache/beam/pull/9351#discussion_r315472687
 
 

 ##########
 File path: sdks/python/container/build.gradle
 ##########
 @@ -60,15 +51,13 @@ golang {
   }
 }
 
-docker {
-  name containerImageName(name: "python")
-  files "./build"
+task buildDocker {
 
 Review comment:
   This change sounds good. 
   
   We could also rename it to just `build` . It would make sense to call it 
like `./gradlew -p sdks/python/container build`
   
   /cc @yifanzou on gradle related questions.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 297531)
    Time Spent: 3h 40m  (was: 3.5h)

> Write integration tests to test customized containers
> -----------------------------------------------------
>
>                 Key: BEAM-7909
>                 URL: https://issues.apache.org/jira/browse/BEAM-7909
>             Project: Beam
>          Issue Type: Sub-task
>          Components: build-system
>            Reporter: Hannah Jiang
>            Assignee: Hannah Jiang
>            Priority: Major
>          Time Spent: 3h 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to