[
https://issues.apache.org/jira/browse/BEAM-7264?focusedWorklogId=297807&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297807
]
ASF GitHub Bot logged work on BEAM-7264:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Aug/19 11:51
Start Date: 20/Aug/19 11:51
Worklog Time Spent: 10m
Work Description: iemejia commented on issue #9373: [BEAM-7264] Remove
set/getClientConfiguration in JdbcIO
URL: https://github.com/apache/beam/pull/9373#issuecomment-522978562
`withDataSourceConfiguration` is the previous (and still) more used API, it
allows the users to pass a configuration object that it is converted into the
request internally by the more generic `withDataSourceProviderFn`. I am a bit
hesitant to deprecate it (or remove it) due to its expanded use and also
because it is more user friendly.
However you may have a point, we should consider as an option to maybe
deprecate it and suggest to the users to use the other more explicit transform.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 297807)
Time Spent: 20m (was: 10m)
> Remove set/getClientConfiguration in JdbcIO
> -------------------------------------------
>
> Key: BEAM-7264
> URL: https://issues.apache.org/jira/browse/BEAM-7264
> Project: Beam
> Issue Type: Improvement
> Components: io-java-jdbc
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: Minor
> Fix For: 2.16.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> BEAM-7263 deprecated these methods and now they can be removed.
> This is a minor clean up to remove the two methods because they are not used
> internally anymore, the `ClientConfiguration` object is now wrapped and
> passed as a function to `withDataSourceProviderFn`. This has almost zero
> impact on end users because the set functionality is already covered by the
> `with` method and the `get` method is not mandatory because the user already
> has the reference.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
