[
https://issues.apache.org/jira/browse/BEAM-7264?focusedWorklogId=297893&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297893
]
ASF GitHub Bot logged work on BEAM-7264:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Aug/19 13:53
Start Date: 20/Aug/19 13:53
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on issue #9373: [BEAM-7264]
Remove set/getClientConfiguration in JdbcIO
URL: https://github.com/apache/beam/pull/9373#issuecomment-523025676
Well, maybe "undetermined" was not a right word for this - I meant that the
creating of final "working" instance of data source provider depends on order
of calling build methods and it can be different depending on user's code. So,
for the same pipeline but with different order of these methods calling, the
results could be different too.
I agree that we don't check calling of the same methods with different
arguments (which is quite logical in general case) but I'd argue that we can
avoid potential ambiguity in such specific case (since
`withDataSourceConfiguration()` calls `withDataSourceProviderFn()` implicitly)
by adding the check I proposed above. For example, we have a similar check in
`KinesisIO`:
```
checkArgument(
getPartitionKey() == null || (getPartitioner() == null),
"only one of either withPartitionKey() or withPartitioner() is
possible");
```
I don't think it will complicate `JdbcIO` API too much. We can have a
different Jira for that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 297893)
Time Spent: 1h 20m (was: 1h 10m)
> Remove set/getClientConfiguration in JdbcIO
> -------------------------------------------
>
> Key: BEAM-7264
> URL: https://issues.apache.org/jira/browse/BEAM-7264
> Project: Beam
> Issue Type: Improvement
> Components: io-java-jdbc
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: Minor
> Labels: backwards-incompatible
> Fix For: 2.16.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> BEAM-7263 deprecated these methods and now they can be removed.
> This is a minor clean up to remove the two methods because they are not used
> internally anymore, the `ClientConfiguration` object is now wrapped and
> passed as a function to `withDataSourceProviderFn`. This has almost zero
> impact on end users because the set functionality is already covered by the
> `with` method and the `get` method is not mandatory because the user already
> has the reference.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
