[
https://issues.apache.org/jira/browse/BEAM-7264?focusedWorklogId=297823&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297823
]
ASF GitHub Bot logged work on BEAM-7264:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Aug/19 12:18
Start Date: 20/Aug/19 12:18
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on issue #9373: [BEAM-7264]
Remove set/getClientConfiguration in JdbcIO
URL: https://github.com/apache/beam/pull/9373#issuecomment-522987913
@iemejia I don't propose to deprecate and remove
`withDataSourceConfiguration` since, yes, it should be heavily used by users.
My point was a bit different, let me explain in more details.
When one calls `withDataSourceConfiguration` then `withDataSourceProviderFn`
will be called implicitly and new instance of data source provider will be
created there. On the hand, if `withDataSourceProviderFn` is called explicitly
in the same transform, then another data source provider will be created and
the order of creating them is undetermined. It looks contradictory and not
obvious for users. So, to avoid such potential ambiguity, we need to not allow
to call these two methods in the same transform. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 297823)
Time Spent: 50m (was: 40m)
> Remove set/getClientConfiguration in JdbcIO
> -------------------------------------------
>
> Key: BEAM-7264
> URL: https://issues.apache.org/jira/browse/BEAM-7264
> Project: Beam
> Issue Type: Improvement
> Components: io-java-jdbc
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: Minor
> Labels: backwards-incompatible
> Fix For: 2.16.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> BEAM-7263 deprecated these methods and now they can be removed.
> This is a minor clean up to remove the two methods because they are not used
> internally anymore, the `ClientConfiguration` object is now wrapped and
> passed as a function to `withDataSourceProviderFn`. This has almost zero
> impact on end users because the set functionality is already covered by the
> `with` method and the `get` method is not mandatory because the user already
> has the reference.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
