[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=301082&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301082
]
ASF GitHub Bot logged work on BEAM-8021:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Aug/19 08:22
Start Date: 26/Aug/19 08:22
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r317496489
##########
File path: runners/google-cloud-dataflow-java/examples/build.gradle
##########
@@ -19,7 +19,7 @@
import groovy.json.JsonOutput
plugins { id 'org.apache.beam.module' }
-applyJavaNature(publish: false, exportJavadoc: false)
+applyJavaNature(publish: false, exportJavadoc: false, setAutomaticModuleName:
false)
Review comment:
I suppose this does not have automtatic module name because people are not
suppose to build from it? We should probably document this as part of
`setAutomaticModuleName`in `BeamModulePlugin.groovy`. In what particular
reasons we do not set automatic module names. I suppose this will be the case
also for some test pure modules like the Elasticsearch ones.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 301082)
Time Spent: 50m (was: 40m)
> Add Automatic-Module-Name headers for Beam Java modules
> --------------------------------------------------------
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
> Reporter: Ismaël Mejía
> Assignee: Lukasz Gajowy
> Priority: Minor
> Time Spent: 50m
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
