[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=301992&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301992
]
ASF GitHub Bot logged work on BEAM-8021:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Aug/19 13:45
Start Date: 27/Aug/19 13:45
Worklog Time Spent: 10m
Work Description: lgajowy commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r318089497
##########
File path: runners/flink/1.5/build.gradle
##########
@@ -28,6 +28,7 @@ project.ext {
main_resources_dirs = ["$basePath/src/main/resources"]
test_resources_dirs = ["$basePath/src/test/resources"]
archives_base_name = 'beam-runners-flink_2.11'
+ automatic_module_name = 'beam.runners.flink.2.11'
Review comment:
I think I misunderstood you before.
I did some thinking - If we decide to name the modules without version
`beam.runners.flink`, we will prevent users from importing 2 different versions
of Flink a once*. Preventing this sounds sane now but will it always be the
case?
According to my knowledge and current reasoning, the answer is "yes". Could
you confirm?
*JPMS will simply refuse to start a modulepath where two modules have the
same name, even if they contain different packages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 301992)
Time Spent: 2h 10m (was: 2h)
> Add Automatic-Module-Name headers for Beam Java modules
> --------------------------------------------------------
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
> Reporter: Ismaël Mejía
> Assignee: Lukasz Gajowy
> Priority: Minor
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
