[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=301878&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301878
]
ASF GitHub Bot logged work on BEAM-8021:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Aug/19 11:13
Start Date: 27/Aug/19 11:13
Worklog Time Spent: 10m
Work Description: lgajowy commented on pull request #9417: [BEAM-8021]
Add Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#discussion_r318023455
##########
File path: runners/google-cloud-dataflow-java/examples/build.gradle
##########
@@ -19,7 +19,7 @@
import groovy.json.JsonOutput
plugins { id 'org.apache.beam.module' }
-applyJavaNature(publish: false, exportJavadoc: false)
+applyJavaNature(publish: false, exportJavadoc: false, setAutomaticModuleName:
false)
Review comment:
I'm still not 100% sure if we should leave modules without these headers, to
be honest. My motivation was to skip it in aggregated docs (javadoc module),
examples and testing modules because we know that people should not depend on
it (do we?). I also find it as a form of discouragement to depend on them so
but a very weak one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 301878)
Time Spent: 1.5h (was: 1h 20m)
> Add Automatic-Module-Name headers for Beam Java modules
> --------------------------------------------------------
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
> Reporter: Ismaël Mejía
> Assignee: Lukasz Gajowy
> Priority: Minor
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
