[ 
https://issues.apache.org/jira/browse/BEAM-8746?focusedWorklogId=346835&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-346835
 ]

ASF GitHub Bot logged work on BEAM-8746:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Nov/19 16:11
            Start Date: 20/Nov/19 16:11
    Worklog Time Spent: 10m 
      Work Description: chadrik commented on pull request #10161: [BEAM-8746] 
Make local job service accessible from external machines
URL: https://github.com/apache/beam/pull/10161#discussion_r348575097
 
 

 ##########
 File path: sdks/python/apache_beam/runners/portability/local_job_service.py
 ##########
 @@ -95,7 +95,7 @@ def create_beam_job(self, preparation_id, job_name, 
pipeline, options):
 
   def start_grpc_server(self, port=0):
     self._server = grpc.server(UnboundedThreadPoolExecutor())
-    port = self._server.add_insecure_port('localhost:%d' % port)
+    port = self._server.add_insecure_port('[::]:%d' % port)
 
 Review comment:
   A slightly new use case.  Instead of throwing away the job server for each 
invocation, we'd like to keep it around for multiple jobs, like we do with the 
Flink job server, then we can use our job-server-ui to view and manage jobs 
there.  
   
   Additionally, we are sub-classing this class (`LocalJobServicer`) to make a 
new kind of job server that is able to proxy other job servers - a middle-man 
for reviewing a job before sending it on to Flink, Direct, Spark, etc. 
   
   As a result we want to stand this service up along with our other 
long-running Beam services.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 346835)
    Time Spent: 50m  (was: 40m)

> Allow the local job service to work from inside docker
> ------------------------------------------------------
>
>                 Key: BEAM-8746
>                 URL: https://issues.apache.org/jira/browse/BEAM-8746
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py-core
>            Reporter: Chad Dombrova
>            Assignee: Chad Dombrova
>            Priority: Major
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Currently the connection is refused.  It's a simple fix. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to