[
https://issues.apache.org/jira/browse/BEAM-8746?focusedWorklogId=347126&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-347126
]
ASF GitHub Bot logged work on BEAM-8746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Nov/19 02:10
Start Date: 21/Nov/19 02:10
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #10161: [BEAM-8746]
Make local job service accessible from external machines
URL: https://github.com/apache/beam/pull/10161#discussion_r348866533
##########
File path: sdks/python/apache_beam/runners/portability/local_job_service.py
##########
@@ -95,7 +95,7 @@ def create_beam_job(self, preparation_id, job_name,
pipeline, options):
def start_grpc_server(self, port=0):
self._server = grpc.server(UnboundedThreadPoolExecutor())
- port = self._server.add_insecure_port('localhost:%d' % port)
+ port = self._server.add_insecure_port('[::]:%d' % port)
Review comment:
I think it'd make sense for this to be parameterized, likely with localhost
as a default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 347126)
Time Spent: 1h 20m (was: 1h 10m)
> Allow the local job service to work from inside docker
> ------------------------------------------------------
>
> Key: BEAM-8746
> URL: https://issues.apache.org/jira/browse/BEAM-8746
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Currently the connection is refused. It's a simple fix.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
