[
https://issues.apache.org/jira/browse/BEAM-8746?focusedWorklogId=348037&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-348037
]
ASF GitHub Bot logged work on BEAM-8746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Nov/19 09:56
Start Date: 22/Nov/19 09:56
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #10161: [BEAM-8746] Make
local job service accessible from external machines
URL: https://github.com/apache/beam/pull/10161#discussion_r349514933
##########
File path: sdks/python/apache_beam/runners/portability/local_job_service.py
##########
@@ -95,7 +95,7 @@ def create_beam_job(self, preparation_id, job_name,
pipeline, options):
def start_grpc_server(self, port=0):
self._server = grpc.server(UnboundedThreadPoolExecutor())
- port = self._server.add_insecure_port('localhost:%d' % port)
+ port = self._server.add_insecure_port('[::]:%d' % port)
Review comment:
It looks ok, but one idea:
>there are two separate hostnames required, one for opening the port for the
server, and one which is delivered to the client for reconnecting to the
staging service.
Wouldn't it work to allow configuration of a `bind` address (e.g. `[::]`)
and a `connect` address (e.g. `service_name`, what is currently returned in
`get_hostname()`)? That way we would give the subclass full control over what
it wants to do. Maybe return this as a tuple to avoid multiple overrides.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 348037)
Time Spent: 1h 40m (was: 1.5h)
> Allow the local job service to work from inside docker
> ------------------------------------------------------
>
> Key: BEAM-8746
> URL: https://issues.apache.org/jira/browse/BEAM-8746
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Currently the connection is refused. It's a simple fix.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
