[
https://issues.apache.org/jira/browse/BEAM-7274?focusedWorklogId=362369&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-362369
]
ASF GitHub Bot logged work on BEAM-7274:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Dec/19 01:12
Start Date: 23/Dec/19 01:12
Worklog Time Spent: 10m
Work Description: reuvenlax commented on pull request #10449: [BEAM-7274]
Implement the Protobuf schema provider for compiled protocol buffers
URL: https://github.com/apache/beam/pull/10449#discussion_r360741829
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/values/RowWithGetters.java
##########
@@ -122,6 +123,15 @@ private Iterable getIterableValue(FieldType elementType,
Object fieldValue) {
cacheKey, i -> getMapValue(type.getMapKeyType(),
type.getMapValueType(), map))
: (T) getMapValue(type.getMapKeyType(), type.getMapValueType(), map);
} else {
+ if (type.isLogicalType(OneOfType.IDENTIFIER)) {
+ OneOfType oneOfType = type.getLogicalType(OneOfType.class);
+ OneOfType.Value oneOfValue = (OneOfType.Value) fieldValue;
+ Object convertedOneOfField =
+ getValue(oneOfValue.getFieldType(), oneOfValue.getValue(), null);
+ return (T)
Review comment:
This is because the current semantics of Row.getValue() is to return the
underlying type and you're expected to call Row.getLogicalTypeValue() to get
the LogicalType value. It's debatable whether that's the best solution for Row,
but there are arguments both ways and I didn't want to change those semantics
here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 362369)
Time Spent: 20h (was: 19h 50m)
> Protobuf Beam Schema support
> ----------------------------
>
> Key: BEAM-7274
> URL: https://issues.apache.org/jira/browse/BEAM-7274
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Alex Van Boxel
> Assignee: Alex Van Boxel
> Priority: Minor
> Time Spent: 20h
> Remaining Estimate: 0h
>
> Add support for the new Beam Schema to the Protobuf extension.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
