[
https://issues.apache.org/jira/browse/BEAM-7274?focusedWorklogId=362368&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-362368
]
ASF GitHub Bot logged work on BEAM-7274:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Dec/19 01:12
Start Date: 23/Dec/19 01:12
Worklog Time Spent: 10m
Work Description: reuvenlax commented on pull request #10449: [BEAM-7274]
Implement the Protobuf schema provider for compiled protocol buffers
URL: https://github.com/apache/beam/pull/10449#discussion_r360741828
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/values/RowWithGetters.java
##########
@@ -122,6 +123,15 @@ private Iterable getIterableValue(FieldType elementType,
Object fieldValue) {
cacheKey, i -> getMapValue(type.getMapKeyType(),
type.getMapValueType(), map))
: (T) getMapValue(type.getMapKeyType(), type.getMapValueType(), map);
} else {
+ if (type.isLogicalType(OneOfType.IDENTIFIER)) {
Review comment:
I thought that originally, however it turns out that the only way to make
OneOf work with the getters framework is to actually handle it explicitly,
otherwise recursive translation fails to work. Happy to pull this out into a
separate PR if you think that's better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 362368)
Time Spent: 19h 50m (was: 19h 40m)
> Protobuf Beam Schema support
> ----------------------------
>
> Key: BEAM-7274
> URL: https://issues.apache.org/jira/browse/BEAM-7274
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Alex Van Boxel
> Assignee: Alex Van Boxel
> Priority: Minor
> Time Spent: 19h 50m
> Remaining Estimate: 0h
>
> Add support for the new Beam Schema to the Protobuf extension.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
