[
https://issues.apache.org/jira/browse/BEAM-7274?focusedWorklogId=362615&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-362615
]
ASF GitHub Bot logged work on BEAM-7274:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Dec/19 18:20
Start Date: 23/Dec/19 18:20
Worklog Time Spent: 10m
Work Description: reuvenlax commented on issue #10449: [BEAM-7274]
Implement the Protobuf schema provider for compiled protocol buffers
URL: https://github.com/apache/beam/pull/10449#issuecomment-568545736
If I remove the OneOf then tests will start failing, because we won't be
able to properly support the codegen for OneOf (basically we would then be
removing OneOf support in protobuf as well).
On Mon, Dec 23, 2019 at 2:39 AM Alex Van Boxel <notificati...@github.com>
wrote:
> *@alexvanboxel* requested changes on this pull request.
>
> Maybe remove the OneOf in the Row (and let's mark it as a known issue). If
> test are green + spotless I'll give a LGTM.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/beam/pull/10449?email_source=notifications&email_token=AFAYJVIB3HZJN2QCPGPQJP3Q2CWQ5A5CNFSM4J6IM3LKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCQCJFUA#pullrequestreview-335844048>,
> or unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AFAYJVOORB4IBJV54TEVGKLQ2CWQ5ANCNFSM4J6IM3LA>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 362615)
Time Spent: 21h 20m (was: 21h 10m)
> Protobuf Beam Schema support
> ----------------------------
>
> Key: BEAM-7274
> URL: https://issues.apache.org/jira/browse/BEAM-7274
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Alex Van Boxel
> Assignee: Alex Van Boxel
> Priority: Minor
> Time Spent: 21h 20m
> Remaining Estimate: 0h
>
> Add support for the new Beam Schema to the Protobuf extension.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
