[ 
https://issues.apache.org/jira/browse/BEAM-8019?focusedWorklogId=411463&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-411463
 ]

ASF GitHub Bot logged work on BEAM-8019:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Mar/20 23:07
            Start Date: 27/Mar/20 23:07
    Worklog Time Spent: 10m 
      Work Description: robertwb commented on pull request #11185: [BEAM-8019] 
Updates Python SDK to handle remote SDK coders and preserve tags added by 
remote SDKs
URL: https://github.com/apache/beam/pull/11185#discussion_r399564877
 
 

 ##########
 File path: sdks/python/apache_beam/pipeline.py
 ##########
 @@ -1110,7 +1117,8 @@ def transform_to_runner_api(transform,  # type: 
Optional[ptransform.PTransform]
             for part in self.parts
         ],
         inputs={
-            tag: context.pcollections.get_id(pc)
+            _may_be_preserve_tag(tag, pc, self.input_tags_to_preserve):
+            context.pcollections.get_id(pc)
             for tag,
             pc in sorted(self.named_inputs().items())
 
 Review comment:
   While we're here, did yapf not like this on the previous line? Maybe write 
`(tag, pc)` (unless it tries to split that too). 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 411463)
    Time Spent: 11.5h  (was: 11h 20m)

> Support cross-language transforms for DataflowRunner
> ----------------------------------------------------
>
>                 Key: BEAM-8019
>                 URL: https://issues.apache.org/jira/browse/BEAM-8019
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-py-core
>            Reporter: Chamikara Madhusanka Jayalath
>            Assignee: Chamikara Madhusanka Jayalath
>            Priority: Major
>          Time Spent: 11.5h
>  Remaining Estimate: 0h
>
> This is to capture the Beam changes needed for this task.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to