[
https://issues.apache.org/jira/browse/BEAM-8019?focusedWorklogId=411477&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-411477
]
ASF GitHub Bot logged work on BEAM-8019:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Mar/20 23:07
Start Date: 27/Mar/20 23:07
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #11185: [BEAM-8019]
Updates Python SDK to handle remote SDK coders and preserve tags added by
remote SDKs
URL: https://github.com/apache/beam/pull/11185#discussion_r399575610
##########
File path: sdks/python/apache_beam/runners/pipeline_context.py
##########
@@ -115,9 +115,12 @@ def get_id_to_proto_map(self):
# type: () -> Dict[str, message.Message]
return self._id_to_proto
- def put_proto(self, id, proto):
+ def get_proto_from_id(self, id):
+ return self.get_id_to_proto_map()[id]
+
+ def put_proto(self, id, proto, ignore_duplicates=False):
# type: (str, message.Message) -> str
- if id in self._id_to_proto:
+ if not ignore_duplicates and id in self._id_to_proto:
Review comment:
If ignore_duplicates=True, should we ensure that the protos are the same?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 411477)
Time Spent: 12.5h (was: 12h 20m)
> Support cross-language transforms for DataflowRunner
> ----------------------------------------------------
>
> Key: BEAM-8019
> URL: https://issues.apache.org/jira/browse/BEAM-8019
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chamikara Madhusanka Jayalath
> Assignee: Chamikara Madhusanka Jayalath
> Priority: Major
> Time Spent: 12.5h
> Remaining Estimate: 0h
>
> This is to capture the Beam changes needed for this task.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
