[
https://issues.apache.org/jira/browse/BEAM-8019?focusedWorklogId=411468&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-411468
]
ASF GitHub Bot logged work on BEAM-8019:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Mar/20 23:07
Start Date: 27/Mar/20 23:07
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #11185: [BEAM-8019]
Updates Python SDK to handle remote SDK coders and preserve tags added by
remote SDKs
URL: https://github.com/apache/beam/pull/11185#discussion_r399570500
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -558,6 +564,14 @@ def run_pipeline(self, pipeline, options):
result.metric_results = self._metrics
return result
+ def _get_encoding_for_external_environment(self, element):
+ if not isinstance(element, ElementTypeHolder):
+ raise Exception(
+ 'Expected to receive an object of type ElementTypeHolder '
+ 'but received %r' % element)
+ from apache_beam.coders.coders import ExternalCoder
Review comment:
Can `apache_beam.coders.coders` not be imported at the top? In which case,
it seems this whole method can be a one-liner at the call site.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 411468)
Time Spent: 11h 50m (was: 11h 40m)
> Support cross-language transforms for DataflowRunner
> ----------------------------------------------------
>
> Key: BEAM-8019
> URL: https://issues.apache.org/jira/browse/BEAM-8019
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chamikara Madhusanka Jayalath
> Assignee: Chamikara Madhusanka Jayalath
> Priority: Major
> Time Spent: 11h 50m
> Remaining Estimate: 0h
>
> This is to capture the Beam changes needed for this task.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
