sijie commented on a change in pull request #643: BP-14 part 2 - client side
changes
URL: https://github.com/apache/bookkeeper/pull/643#discussion_r145544977
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
##########
@@ -477,6 +478,30 @@ void
connectIfNeededAndDoOp(GenericCallback<PerChannelBookieClient> op) {
}
+ void sync(final long ledgerId, final byte[] masterKey, final long entryId,
+ BookkeeperInternalCallbacks.SyncCallback cb, final Object ctx) {
+ final long txnId = getTxnId();
+ final CompletionKey completionKey = new V3CompletionKey(txnId,
+
OperationType.SYNC);
+ completionObjects.put(completionKey,
+ new SyncCompletion(completionKey, cb, ledgerId,
ctx));
+
+ // Build the request
+ BKPacketHeader.Builder headerBuilder = BKPacketHeader.newBuilder()
+ .setVersion(ProtocolVersion.VERSION_THREE)
+ .setOperation(OperationType.WRITE_LAC)
Review comment:
operation is wrong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
